On 10/06/16 15:55, Kyrill Tkachov wrote:
> Hi all,
>
> This function just ICEs and isn't actually called from anywhere.
> It was introduced back in 2000 as part of a large merge introducing
> Thumb support
> and was aborting even then. I don't think having it around is of any
> benefit.
>
> Tested on arm-none-eabi.
>
> Ok for trunk?
>
OK. If it's never used, then deleting useless dead code like this is
obvious IMO.
R.
> Thanks,
> Kyrill
>
> 2016-06-10 Kyrylo Tkachov <kyrylo.tkac...@arm.com>
>
> * config/arm/arm.c (thumb_reload_in_hi): Delete.
> * config/arm/arm-protos.h (thumb_reload_in_hi): Delete prototype.
>
> thumb_reload_in_hi.patch
>
>
> diff --git a/gcc/config/arm/arm-protos.h b/gcc/config/arm/arm-protos.h
> index
> b6981bcfb9070787cb7472b00c24e0f86a2cae1f..888aaf944a7974d61d96f356a94acefa8e9a2f21
> 100644
> --- a/gcc/config/arm/arm-protos.h
> +++ b/gcc/config/arm/arm-protos.h
> @@ -193,7 +193,6 @@ extern const char *thumb_call_via_reg (rtx);
> extern void thumb_expand_movmemqi (rtx *);
> extern rtx arm_return_addr (int, rtx);
> extern void thumb_reload_out_hi (rtx *);
> -extern void thumb_reload_in_hi (rtx *);
> extern void thumb_set_return_address (rtx, rtx);
> extern const char *thumb1_output_casesi (rtx *);
> extern const char *thumb2_output_casesi (rtx *);
> diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c
> index
> 70e52546bc45c404788713c535e116e591ec5d4e..1618a1eaaa3a9902f45a15f3de5b524a4dfbebb8
> 100644
> --- a/gcc/config/arm/arm.c
> +++ b/gcc/config/arm/arm.c
> @@ -25670,13 +25670,6 @@ thumb_reload_out_hi (rtx *operands)
> emit_insn (gen_thumb_movhi_clobber (operands[0], operands[1],
> operands[2]));
> }
>
> -/* Handle reading a half-word from memory during reload. */
> -void
> -thumb_reload_in_hi (rtx *operands ATTRIBUTE_UNUSED)
> -{
> - gcc_unreachable ();
> -}
> -
> /* Return the length of a function name prefix
> that starts with the character 'c'. */
> static int
>
