On 6/27/16 8:30 PM, Peter Bergner wrote:
On 6/27/16 3:21 PM, Segher Boessenkool wrote:
On Sat, Jun 25, 2016 at 07:14:01PM -0500, Peter Bergner wrote:
Okay for trunk, okay for 6 later.  One comment:

+  if (VECTOR_MODE_P (mode)
+      && !mode_supports_vsx_dform_quad (mode))
+    return false;

   if (GET_CODE (addr) != PLUS)
     return false;

   op0 = XEXP (addr, 0);
-  if (!base_reg_operand (op0, Pmode))
+  if (!REG_P (op0)
+      || !INT_REG_OK_FOR_BASE_P (op0, strict))
     return false;

Just put these short conditionals on one line each?  It looks silly ;-)

Ok, committed to trunk with that change.  Thanks!

Pat noticed the second test case I added failed on our old regtesters.
It seems the creduce minimization process removed too much code.
I have committed the following to fix the syntax errors he was seeing.

Peter


        PR target/71656
        * gcc.target/powerpc/pr71656-2.c: Fix syntax errors.

Index: gcc/testsuite/gcc.target/powerpc/pr71656-2.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/pr71656-2.c        (revision 237822)
+++ gcc/testsuite/gcc.target/powerpc/pr71656-2.c        (revision 237823)
@@ -17,7 +17,7 @@
 void func1 (vec);

 void
-func2 (double *)
+func2 (double *b)
 {
   for (; k; k--)
     for (; j <= k;)
@@ -33,7 +33,7 @@
 void
 func3 (void)
 {
-  vec_t d;
+  struct vec_t d;
   func1 (d.y);
   func2 (&b);
   for (; a;)


Reply via email to