On 03/05/16 11:56, Andrew Burgess wrote:
* Claudiu Zissulescu <claudiu.zissule...@synopsys.com> [2016-05-02 09:02:16
+0000]:
Please also consider to address also the following warnings introduced:
mainline/gcc/gcc/config/arc/arc.md:888: warning: source missing a mode?
mainline/gcc/gcc/config/arc/arc.md:906: warning: source missing a mode?
mainline/gcc/gcc/config/arc/arc.md:921: warning: source missing a mode?
mainline/gcc/gcc/config/arc/arc.md:6146: warning: source missing a mode?
Here's a revised fixup patch that includes addressing these 4
warnings.
This the the wrong approach.
zn_compare_operator is a special predicate that accepts CC_ZNmode as
well as CC_Zmode.
The point is that some comparison uses need Z and N set, while other are
OK with just Z.
Not accepting CC_Zmode would cause spurious recognition rejections.
A generator program complaining about a missing mode for an operand with
a special predicate
is wrong.
from md.texi:
: Predicates written with @code{define_special_predicate} do not get any
: automatic mode checks, and are treated as having special mode handling
: by @command{genrecog}.