On Thu, 9 Jun 2016, Nathan Sidwell wrote: > > (define_expand "restore_stack_block" > > [(match_operand 0 "register_operand" "") > > (match_operand 1 "register_operand" "")] > > you've not addressed my previous comments about this.
To be clear -- do you mean that "restore_stack_block" should have a comment mentioning why "save_stack_block" is not overridden? > > @@ -0,0 +1,25 @@ > > > +char *__nvptx_stacks[32] __attribute__((shared,nocommon)); > > Is there a reason this can't be in crt0? It's also needed for offloading compilation, which doesn't link crt0. > It should be 'void *' Also, why '32' when only slot zero is initialized? > ISTM that this should be size 1. Offloading will need the full width. Thanks. Alexander
