On 06/08/2016 03:47 AM, Segher Boessenkool wrote:
This patch series introduces separate shrink-wrapping.
[...]
The next six patches are to prevent later passes from mishandling the
epilogue instructions that now appear before the epilogue: mostly, you
cannot do much to instructions with a REG_CFA_RESTORE note without
confusing dwarf2cfi.  The cprop one is for prologue instructions.

I'll need a while to sort out my thoughts about this. On the whole I like having the ability to do this, but I'm worried about the fragility it introduces in passes after shrink-wrapping. Ideally we'd need an ix86 implementation for test coverage reasons.

Is the usage of the word "concern" here standard for this kind of thing? It seems odd somehow but maybe that's just me.


Bernd

Reply via email to