On 05/23/2016 03:58 PM, Mikhail Maltsev wrote:
This patch refactors 'noce_try_store_flag_constants' a bit to make it easier to
reason about.
The function contains two series of conditions, and each branch of the second
series corresponds to one or two branches of the first series. The patch
introduces a new enumeration strategy_t instead and uses it to select the
correct branch. Also, ISTM that the last 'else' branch is unreachable.
Bootstrapped and regtested on x86_64-linux. OK for trunk?
Please send patches as text/plain or text/x-patch attachments so they
can be read and quoted.
+ bool can_reverse
+ = (reversed_comparison_code (if_info->cond, if_info->jump) !=
UNKNOWN);
Parens not needed anymore if the line is split this way. Otherwise OK.
Maybe the test for common without ST_ADD_FLAG could be moved up a little
to avoid unnecessary operations.
Bernd
