On Thu, May 26, 2016 at 03:59:43PM -0500, Segher Boessenkool wrote: > On Thu, May 26, 2016 at 01:04:59PM -0400, Michael Meissner wrote: > > * config/rs6000/rs6000.md (SFDF2): New iterator to allow doing > > conditional moves there the comparison type is different from move > > type. > > s/there/where/ ? > > > <fsf submission> > > Don't forget to delete this line ;-)
Whoops :-) > > +/* { dg-require-effective-target powerpc_p9vector_ok } */ > > +/* { dg-options "-mcpu=power9 -O2 -mpower9-minmax -ffast-math" } */ > > Does it still need this require if you have these options? Yes it needs -ffast-math. Right now, you need -ffast-math to convert: a = (b >= c) ? b : c; into a max, but you don't for: a = (b > c) ? b : c; p9-minmax-1.c tests whether both cases are handled with -ffast-math, while p9-minmax-2.c tests whether just the second case is handled without -ffast-math. > The patch is okay for trunk; okay for 6 later. Thanks, > > > Segher > -- Michael Meissner, IBM IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA email: meiss...@linux.vnet.ibm.com, phone: +1 (978) 899-4797