On May 24, 2016, at 9:50 PM, Daniel Krügler <daniel.krueg...@gmail.com> wrote: > > 2016-05-23 13:50 GMT+02:00 Jonathan Wakely <jwak...@redhat.com>: >> On 17/05/16 20:39 +0200, Daniel Krügler wrote: >>> >>> This is an implementation of the Standard is_swappable traits according to >>> >>> http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0185r1.html >>> >>> During that work it has been found that std::array's member swap's >>> exception >>> specification for zero-size arrays was incorrectly depending on the >>> value_type >>> and that was fixed as well. >> >> This looks good to me, I'll get it committed (with some adjustment to >> the ChangeLog format) - thanks. > > Unfortunately I need to withdraw the suggested patch. Besides some > obvious errors there are issues that require me to get the testsuite > run on my Windows system, which had not yet succeeded. > > I would appreciate, if anyone who has succeeded to run the test suite > on a Windows system (preferably mingw), could contact me off-list.
So, you can fix up the code that matters, and re-post the that code, and merely say the patch doesn't have testing on it and ask others to run the test suite for you. Once you hear back and that the patch tests out well, you can then seek approval for inclusion, even though you never tested it. Longer term, it is handy to be able to run the test suite yourself... If Windows proves to be a pain, you you can run a VM with linux on it, and then run the test suite in the linux VM on windows. Also, you can grab cygwin, testing there should be very, very close to just install cygwin, make && make check.
