On Tue, 2016-05-17 at 18:49 -0400, Trevor Saunders wrote:
> On Tue, May 17, 2016 at 06:01:32PM -0400, David Malcolm wrote:
> > This implements the libgccjit support for must-tail-call via
> > a new:
> >   gcc_jit_rvalue_set_bool_require_tail_call
> > API entrypoint.
> 
> It seems to me like that's not a great name, the rvalue and bool
> parts
> are just about the argument types, not what the function does. 
>  Wouldn't
> gcc_jit_set_call_requires_tail_call be better?

Maybe.  I was thinking of it from the point of view of methods; it's
effectively a method on gcc_jit_rvalue.  The "set_bool" is for
consistency with various gcc_jit_context_ entrypoints.

FWIW, I've committed the patch as-is; all of the must-tail-call patches
are now in trunk, as of r236531.

Reply via email to