On Fri, 20 May 2016, Jakub Jelinek wrote: > On Fri, May 20, 2016 at 01:40:01PM +0200, Marek Polacek wrote: > > > + if (lhs > > > + && (gimple_call_flags (stmt) & ECF_NORETURN) > > > + && (VOID_TYPE_P (TREE_TYPE (gimple_call_fntype (stmt))) > > > + || ((TREE_CODE (TYPE_SIZE_UNIT (TREE_TYPE (lhs))) > > > + == INTEGER_CST) > > > + && !TREE_ADDRESSABLE (TREE_TYPE (lhs))))) > > > > Do you think it would be worth it to factor out this check into a new > > predicate and use it throughout the codebase? > > I think it would be worthwhile. Are you willing to write a patch for this? > Otherwise I can add it to my todo list, but it will take a while.
Maybe even make it a maybe_drop_lhs_from_noreturn_call () helper. Richard.
