On 19 May 2016 at 19:40, Jason Merrill <ja...@redhat.com> wrote: > On 05/05/2016 09:11 AM, Ville Voutilainen wrote: >> >> On 5 May 2016 at 13:36, Paolo Carlini <paolo.carl...@oracle.com> wrote: >>> >>> .. minor nit: the new testcase has a number of trailing blank lines. >> >> >> New patch attached. :) > > > Sorry for the delay. > > Please use ".diff" for patches so that they are properly recognized as > text/x-patch. > > The patch looks good, but it could use a comment explaining what it's doing.
I'll add some comments into it. > Any thoughts on doing something similar for extern variable declarations? Ah, we diagnose local extern variable declarations that clash with previous declarations, but we don't diagnose cases where a subsequent declaration clashes with a previous local extern declaration. I'll take a look.
