On Thu, May 19, 2016 at 04:16:53PM -0500, Bill Seurer wrote:
> 2016-05-19  Bill Seurer  <seu...@linux.vnet.ibm.com>
> 
>       * config/rs6000/rs6000-builtin.def (vec_addec): Change vec_addec to a
>       special case builtin.
>       * config/rs6000/rs6000-c.c (altivec_resolve_overloaded_builtin): Add
>       support for ALTIVEC_BUILTIN_VEC_ADDEC.
>       * config/rs6000/rs6000.c (altivec_init_builtins): Add definition
>       for __builtin_vec_addec.
> 
> [gcc/testsuite]
> 
> 2016-05-19  Bill Seurer  <seu...@linux.vnet.ibm.com>
> 
>       * gcc.target/powerpc/vec-addec.c: New test.
>       * gcc.target/powerpc/vec-addec-int128.c: New test.

Okay for trunk.  A few trivial formatting nits left...

> +      /* All 3 arguments must be vectors of (signed or unsigned) (int or
> +     __int128) and the types must match.  */
> +      if (arg0_type != arg1_type || arg1_type != arg2_type)
> +     goto bad; 
> +      if (TREE_CODE (arg0_type) != VECTOR_TYPE)
> +     goto bad; 
> +
> +      switch (TYPE_MODE (TREE_TYPE (arg0_type)))
> +     {
> +       /* For {un}signed ints, 

Trailing spaces (this last line and the two "bad"s).

> +         arg0 = save_expr(arg0);
> +         arg1 = save_expr(arg1);

Missing space before the (.

> +         tree const1 = build_int_cstu(TREE_TYPE (arg0_type), 1);

And here.

> +       case TImode: 

Trailing space.

Thanks,


Segher

Reply via email to