On Thursday 19 May 2016 17:18:29 Kyrill Tkachov wrote: > Hi Thomas, > > On 17/05/16 11:15, Thomas Preudhomme wrote: > > Ping? > > > > *** gcc/ChangeLog *** > > > > 2015-12-17 Thomas Preud'homme <thomas.preudho...@arm.com> > > > > * config/arm/arm.h (TARGET_HAVE_LDACQ): Enable for ARMv8-M > > Mainline. > > > > diff --git a/gcc/config/arm/arm.h b/gcc/config/arm/arm.h > > index > > 347b5b0a5cc0bc1e3b5020c8124d968e76ce48a4..e154bd31b8084f9f45ad4409e7b38de6 > > 52538c51 100644 > > --- a/gcc/config/arm/arm.h > > +++ b/gcc/config/arm/arm.h > > @@ -266,7 +266,7 @@ extern void (*arm_lang_output_object_attributes_hook) > > (void); > > > > || arm_arch7) && arm_arch_notm) > > > > /* Nonzero if this chip supports load-acquire and store-release. */ > > > > -#define TARGET_HAVE_LDACQ (TARGET_ARM_ARCH >= 8 && arm_arch_notm) > > +#define TARGET_HAVE_LDACQ (TARGET_ARM_ARCH >= 8 && TARGET_32BIT) > > So this change is correct because ARMv8-M Mainline uses Thumb2 > and is therefore TARGET_32BIT. > > This is ok but I'd like to see a follow up patch to enable the tests > that exercise acquire-release instructions in the arm.exp testsuite > for ARMv8-M Mainline so that we can be sure they get proper testsuite > coverage.
Good thing I already have one around. I need to separate it from other stuff though, so I'll probably send it on Monday. Cheers, Thomas
