Re: [PATCH] PR c++/71184: Fix NULL dereference in cp_parser_operator

[Jason Merrill]

On 05/18/2016 08:59 PM, David Malcolm wrote:

+           cp_token *close_token =
+             cp_parser_require (parser, CPP_CLOSE_SQUARE, RT_CLOSE_SQUARE);
+           if (close_token)
+             end_loc = close_token->location;

You could combine these into

if (cp_token *close_token
    = cp_parser_require (parser, CPP_CLOSE_SQUARE, RT_CLOSE_SQUARE);
  end_loc = close_token->location;

(also splitting the line before the = rather than after).

OK.

Jason