On 05/11/2016 08:56 AM, Jakub Jelinek wrote:
On Wed, May 11, 2016 at 04:47:46PM +0200, Martin Liška wrote:
Thank you Jakub for the note. What about the second version of the patch?
Thanks,
Martin
>From da688c187067dc5c475a4ab5b844c11c4bcd0494 Mon Sep 17 00:00:00 2001
From: marxin <mli...@suse.cz>
Date: Wed, 11 May 2016 16:05:49 +0200
Subject: [PATCH] Document ASAN_OPTIONS="halt_on_error" env variable.
gcc/ChangeLog:
2016-05-11 Martin Liska <mli...@suse.cz>
* doc/invoke.texi: Explain connection between -fsanitize-recover=address
and ASAN_OPTIONS="halt_on_error=1".
---
gcc/doc/invoke.texi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index a54a0af..282367d 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -9998,6 +9998,12 @@ for which this feature is experimental.
accepted, the former enables recovery for all sanitizers that support it,
the latter disables recovery for all sanitizers that support it.
+Even if a recovery mode is turned on, it can be overridden by providing
+@code{halt_on_error=1} to one of the following environment variables:
+@env{ASAN_OPTIONS}, @env{TSAN_OPTIONS}, @env{UBSAN_OPTIONS}.
+The default value is set to @code{halt_on_error=0} for all options,
+except @env{ASAN_OPTIONS}.
+
I think it better should say that:
Even if a recovery mode is turned on the compiler side, it needs to be also
enabled on the runtime library side, otherwise the failures are still fatal.
The runtime library defaults to ... and this can be overridden through ...
or so.
Yes, please. I cannot understand either of the first two versions of
the patch.
-Sandra
