On May 10, 2016 6:59:31 PM GMT+02:00, Bernd Schmidt <bschm...@redhat.com> wrote: >On 05/10/2016 06:19 PM, Ilya Enkovich wrote: >> Curretly CSE may modify CFG and leave invalid dominance info. This >patch >> improves track of CFG changes by CSE passes and frees dominance info >if >> required. This allows to remove corresponding workaround from STV >pass. >> >> Does it look OK? > >Better tracking of cse_cfg_altered seems good regardless. So that's an >OK for everything but... > >> + if (cse_cfg_altered && dom_info_available_p (CDI_DOMINATORS)) >> + free_dominance_info (CDI_DOMINATORS); > >I wonder whether it should be the last user of dominance info that >should be freeing it (maybe it's not just cse that can destroy it?) > >Which pass is leaving it around?
Dominators are never freed. Richard. > >Bernd
