Hi Rainer! On Fri, Apr 29, 2016 at 10:58:25 +0200, Rainer Orth wrote: > > On 04/26/2016 08:04 AM, Rainer Orth wrote: > >> When working on a couple of Cilk Plus issues lately (PRs target/60290, > >> target/68945), I noticed that you have to modify the libcilkplus sources > >> to enable various debugging output. This seems silly, and the following > >> patch allows defining them from the command line. > >> > >> Tested on i386-pc-solaris2.12 and sparc-sun-solaris2.12. > >> > >> Ok for mainline? > >> > >> Rainer > >> > >> > >> 2016-04-07 Rainer Orth <r...@cebitec.uni-bielefeld.de> > >> > >> * runtime/except-gcc.cpp (DEBUG_EXCEPTIONS): Allow redefinition. > >> * runtime/cilk_fiber.h (FIBER_DEBUG): Likewise. > >> * runtime/scheduler.h (REDPAR_DEBUG): Likewise. > > Ilya will have to chime in here -- we're a downstream consumer of the Cilk+ > > runtime. So these patches need to go into Intel's tree first, then Ilya > > can bring them into the GCC tree. > > I suspected that much. It would be good to have a libcilkrts/README.gcc > describing the rules which changes can go into the gcc tree directly, > which need to go upstream first, and how. libo and libsanitizer already > have this.
Could you please submit your patch to <www.cilkplus.org/submit-cilk-contribution>? All patches for libcilkrts/* should go there first in order to avoid possible license issues, or possible losses during the merge. Thanks, -- Ilya
