On Thu, Apr 28, 2016 at 06:03:38PM +0200, Jakub Jelinek wrote: > On Thu, Apr 28, 2016 at 03:57:38PM +0000, Segher Boessenkool wrote: > > On various PowerPC configurations, the top frame is often mentioned > > twice in the backtrace, making many asan tests fail. I see no particular > > reason the asan tests want to check the frame number, so this patch > > makes it check for " #. " instead of " #1 ", etc., in all of the > > c-c++-common/asan tests. > > Wouldn't it be better to fix the backtrace stuff for PowerPC, so that > the top frame is not mentioned twice when it shouldn't?
Yes, but should this cause over a hundred asan tests to fail? The actual things those tests test work fine, just the backtrace is a little funny (and people are used to that, things have worked this way for as long as I can remember -- maybe it even cannot be fixed?). > I mean, if it annoys the tests (where IMHO it is still useful to test > the numbers, to avoid e.g. having some unrelated frames being printed first > or bugs like this to be caught), it will annoy users as well. How about I leave #0 in place, only replace #1 etc. by #. ? Segher
