On 20/04/16 13:12, Claudiu Zissulescu wrote:
This patch adds new instruction variants as introduced by the ARCv2
architecture.
You have used groups of 8 spaces at line starts; tabs should be used
instead for indentation.
(arc_dwarf_register_span): Remove enum keyword.
That bit should be separate.
(compact_memory_operand_p): New function.
The description of the arguments in the start-of-function comment
does not agree with how the arguments are used in the definition of the
"UTS" .
Moreover, it says:
CODE_DENSITY indicates ARCv2 code density operations are
+ available
which implies that these are additional opcodes that are available, yet for the
base+index register case, we have:
+ {
+ return !code_density;
+ }
Considering this comment:
+ /* Reverting for the moment since ld/st{w,h}_s does not have sp
+ as a valid parameter. */
The historical context is utterly lost, so the "Reverting for the moment since"
bit only confuses.
