On 03/28/2016 06:44 AM, Andi Kleen wrote:
From: Andi Kleen <a...@linux.intel.com>
Add support for profiledbootstrap with autofdo. Will be useful
to get better testing coverage of autofdo.
Is this the only purpose? I'll admit this is the patch I like least out
of the series.
The autofdo'ed compiler is ~7% faster on insn-recog.i (vs ~11% for
profiledfeedback), and ~4% faster for tramp3d-v4 (vs 10% for
profiledfeedback)
So it seems like we get worse results than with a feature we already
have, so I don't quite see the value.
+AUTO_PROFILE = gcc-auto-profile -c 1000000
Shouldn't this be from $(srcdir) somewhere?
+# get from configure?
+CREATE_GCOV = create_gcov
Probably.
Please remove diffs against autogenerated files when submitting patches.
+ifeq ($(shell cat ../stage_current),stageautofeedback)
+$(CXX_AND_OBJCXX_OBJS): CFLAGS += -fauto-profile=cc1plus.fda
+$(CXX_AND_OBJCXX_OBJS): cc1plus.fda
+endif
+cc1.fda: ../stage1-gcc/cc1$(exeext) ../prev-gcc/$(PERF_DATA)
+ $(CREATE_GCOV) -binary ../stage1-gcc/cc1$(exeext) -gcov cc1.fda
-profile ../prev-gcc/$(PERF_DATA) -gcov_version 1
+
These Makefile bits all looks somewhat hackish to me. I'll defer to
build system maintainers if they like it better.
Bernd
