On Tue, Apr 12, 2016 at 01:14:51PM -0500, Evandro Menezes wrote: > On 04/05/16 17:30, Evandro Menezes wrote: > >On 04/05/16 13:37, Wilco Dijkstra wrote: > >>I can't get any of these to work... Not only do I get a large > >>number of collisions and duplicated > >>code between these patches, when I try to resolve them, all I > >>get is crashes whenever I try > >>to use sqrt (even rsqrt stopped working). Do you have a patchset > >>that applies cleanly so I can > >>try all approximation routines? > > > >The original patches should be independent of each other, so > >indeed they duplicate code. > > > >This patch suite should be suitable for testing.
Take look at other patch sets posted to this list for examples of how to make review easier. Please send a series of emails tagged: [Patch 0/3 AArch64] Add infrastructure for more approximate FP operations [PATCH 1/3 AArch64] Add more choices for the reciprocal square root approximation [PATCH 2/3 AArch64] Emit square root using the Newton series [PATCH 3/3 AArch64] Emit division using the Newton series One patch per email, with the dependencies explicit like this, is infinitely easier to follow than the current structure of your patch set. I'm not trying to be pedantic for the sake of it, I'm genuinely unsure where the latest patch versions currently are and how I should apply them to a clean tree for review. Thanks, James
