>> > There is for example (currently) no special handling for operators. >> >> Well, unfortunately one cannot just return "-3" for non-matching >> operators. Just think of cases like A*(B+C) vs A*B+A*C. > Ah yes. I was thinking expressions themselves were compared; but only their > values are.
I'm not sure I'm getting you right here. Of course we do compare the expressions themselves. However, for example things like commutativity of operators are taken into account, meaning we compare "A+B" equal to "B+A" (A and B being arbitrary expressions). Taking care of other algebraic transformations (like e.g. distributivity as mentioned above) will be a bit harder. And the question is we are even allowed to do it. Earlier in this thread Steve mentioned restrictions like Note 7.18. X*(Y-Z) -> X*Y - X*Z is a forbidden transformation (there is no noted restriction on Z > 0). >> I'll commit the patch (as posted) tomorrow, if Mikael agrees that the >> description is ok. > It's fine. Thanks. Committed as r177932. Thanks again for your review and comments. Cheers, Janus
