Done. Patch attached in previous mail
K
On Fri, Aug 19, 2011 at 6:51 PM, Kirill Yukhin <kirill.yuk...@gmail.com> wrote:
> On Fri, Aug 19, 2011 at 6:31 PM, H.J. Lu <hjl.to...@gmail.com> wrote:
>> It is hard to tell. Can you double check indentation on
>>
>> + if (can_create_pseudo_p () && <MODE>mode != SImode)
>> + {
>> + rtx tmp = gen_rtx_REG (<MODE>mode, 0);
>> + emit_insn (gen_extendsidi2 (tmp, operands[2]));
>> + operands[2] = tmp;
>> + }
>>
>>
>> On Fri, Aug 19, 2011 at 7:13 AM, Kirill Yukhin <kirill.yuk...@gmail.com>
>> wrote:
>>> Thanks, fixed.
>>>
>>> Updated patch is attached.
>>>
>>> K
>>>
>>> On Fri, Aug 19, 2011 at 6:04 PM, H.J. Lu <hjl.to...@gmail.com> wrote:
>>>> No need for () in "(mode == SImode)":
>>>>
>>>> + && !optimize_function_for_size_p (cfun)
>>>> + && ((mode == SImode) || (mode == DImode && TARGET_64BIT))
>>>>
>>>> Wrong placement of '{':
>>>>
>>>> + if (can_create_pseudo_p () && <MODE>mode != SImode) {
>>>> + rtx tmp = gen_rtx_REG (<MODE>mode, 0);
>>>> + emit_insn (gen_extendsidi2 (tmp, operands[2]));
>>>> + operands[2] = tmp;
>>>> + }
>>>>
>>>>
>>>>
>>>> On Fri, Aug 19, 2011 at 6:53 AM, Kirill Yukhin <kirill.yuk...@gmail.com>
>>>> wrote:
>>>>> Thanks!
>>>>> Fixed, updated patch is attached.
>>>>>
>>>>> Is it ok?
>>>>>
>>>>> Thanks, K
>>>>>
>>>>> On Fri, Aug 19, 2011 at 5:22 PM, Jakub Jelinek <ja...@redhat.com> wrote:
>>>>>> On Fri, Aug 19, 2011 at 05:18:19PM +0400, Kirill Yukhin wrote:
>>>>>>> Thanks, it is fixed.
>>>>>>> Update patch is attached.
>>>>>>
>>>>>> + /* We generatin RORX instruction, freedom of register +
>>>>>> + flags not affected */
>>>>>>
>>>>>> comment doesn't look to be correct english (missing verb, missing g at
>>>>>> the end of generating, missing dot at the end of sentence).
>>>>>>
>>>>>> Jakub
>>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> H.J.
>>>>
>>>
>>
>>
>>
>> --
>> H.J.
>>
>
