I've had it in a successful test run, and committed it with a minor tweak (__builtin_abort vs return 1).

It didn't find anything, but it's probably good to have.

As for the docs, I think you are unnecessarily worried about things that are never going to be a problem in practice.

Perhaps so. On the other hand, the reason x86 always clobbers cc now is that there was a concern during a change that people may have been using it incorrectly. Giving people yet another way to muck this up seemed like a bad plan.

Anyway.

There were basically 3 changes I was trying for in that doc patch. Are any of them worth keeping? Or are we done?

1) "Do not clobber flags if they are being used as outputs."
2) Output flags sample (with #if removed).
3) "On the x86 platform, flags are always treated as clobbered by extended asm whether @code{"cc"} is specified or not."

I'm prepared to send an updated patch if there's anything here that might get approved.

dw

Reply via email to