On 04/04/2016 09:39 AM, Eric Botcazou wrote:
The audit trail of the PR is quite confused: __LIBGCC_EH_FRAME_SECTION_NAME__ needs to be (and is correctly) defined during the libgcc build because DWARF2 exceptions are used. The problem is that libgcc2.c expects the usual non-ELF setup, with __EH_FRAME_BEGIN__ defined in crtstuff.c. Now t-cygwin has:
That's t-cygming, not t-cygwin, right?
This code is already entirely skipped for Cygwin because of: #ifndef __CYGWIN__ so the attached patch adds a similar test on MinGW for the problematic code. Tested on x86/Windows configured with --disable-sjlj-exceptions --with-dwarf2, OK for the mainline and 5 branch?
It looks plausible. One could argue that gcc shouldn't define __LIBGCC_EH_FRAME_SECTION_NAME__ in this case, but since it's used in cygming-crtbegin.c, that seems to gain relatively little.
So, I think this is ok. Bernd
