On Mon, Mar 28, 2016 at 2:44 PM, Bernd Edlinger <bernd.edlin...@hotmail.de> wrote: > > Hi, > > as described in the tracker we have bootstrap problems with in-tree gmp-6.1.0 > on certain targets, and also a linker issue with check-mpc due to the changed > mpfr library path.
Hum, in-tree gmp 6.1.0 is not supported (only the version downloaded by download_prerequesites is). > These are triggered by overriding CFLAGS and LDFLAGS in in-tree builds. > It did not happen with the gmp/mpfr/mpc versions that download_prerequisites > installs, but the currently latest version of these libraries use CFLAGS to > pass > -DNO_ASM which is overridden by gcc and causes the gmp-6.1.0 to be > mis-compiled. So you pass down AM_CFLAGS=-DNO_ASM but how does that reliably work for all gmp versions? > And the mpc issue is triggered by overriding LDFLAGS > and the changed mpfr library path. So this started with mpfr v3.1.0 which > moved the sources into a src sub-directory. > > The proposed patch fixes these problems by passing -DNO_ASM in AM_CFLAGS, > and adding both possible mpfr library paths to HOST_LIB_PATH_mpfr. > I've also adjusted HOST_LIB_PATH_mpc although it did not yet create problems. But you remove a possibly good .libs lib_path. > Boot-strapped and regression tested on x86_64-pc-linux-gnu, with different > gmp versions including the latest snapshot. > I have additionally built arm cross compilers, which was not working before. > > Is this OK for trunk? I don't think so. Supporting an arbitrary mix of in-tree versions is a nightmare. If you really want to go down this route see @extra_mpc_gmp_configure_flags@ and add a variant for the lib-paths. I don't have a good answer for -DNO_ASM than to fix gmp/mpfr to not pass down this kind of configuation via CFLAGs. Please instead do the testing required to ensure bumping the versions downloaded by download_prerequesite works during next stage1. Richard. > > Thanks > Bernd.
