Paolo,

> On 08/15/2011 02:05 PM, Joseph S. Myers wrote:
>>> >  This patch almost completes the build side of the libgcc moves.  It
>>> >  moves the libgcc_tm_file support to libgcc/config.host (tm_file), where
>>> >  it belongs.  It builds on a patch Paolo posted some time ago, with some
>>> >  minor corrections (introducing the required dependencies on the
>>> >  generated libgcc_tm.h).  I've removed libgcc_tm.h from tm.h and include
>>> >  the file directly in all libgcc sources that currently include tm.h.
>> What about the Ada files that get built for both the host and the target
>> (or maybe just for the target in some cases) and include tm.h?  Might not
>> some of them require macros that will end up being moved to libgcc_tm.h?
>> What about libobjc files?  I think the target macros in those files need
>> checking to make sure that libgcc_tm.h won't be the right solution for
>> them, or else it should be included in those files when built for the
>> target.
>
> Right. :(  Rainer, please hold the patch.

I didn't mean to apply it until the preceding ones are in...

I've now checked the list of defines in headers referenced from
libgcc/config.host (tm_file)

        CMPtype
        CREATE_DOUBLE_SHIFT
        DECLARE_LIBRARY_RENAMES
        DF
        DI
        FLOAT_ONLY
        LIBGCC2_FIXEDBIT_GNU_PREFIX
        LIBGCC2_GNU_PREFIX
        RENAME_LIBRARY

against the files (outside of gcc and libgcc) which include tm.h:

        gcc/ada/gcc-interface/cuintp.c
        gcc/ada/gcc-interface/decl.c
        gcc/ada/gcc-interface/misc.c
        gcc/ada/gcc-interface/targtyps.c
        gcc/ada/gcc-interface/trans.c
        gcc/ada/gcc-interface/utils.c
        gcc/ada/gcc-interface/utils2.c
        gcc/ada/raise-gcc.c
        gcc/ada/targext.c
        libdecnumber/dconfig.h
        libobjc/encoding.c
        libobjc/sendmsg.c
        libobjc/thr.c

None of them uses any of those macros, so I think we're safe.

        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Reply via email to