On Thu, Feb 25, 2016 at 11:35:07AM +0100, Pierre-Marie de Rodat wrote: > As I said at the end of a message in another thread > (https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01078.html), I always feel > uncomfortable writing brittle dg-scan testcases, hence the current lack of > testcases for those DWARF changes.
I agree that catching this in scan-assembler test is hard, but guality test would catch this. It is true that some guality tests (mostly the ones that test behaviour of optimized code, which differs a lot between different architectures) have known FAILs (or known XFAILs), because the target, compilation options and gdb version matrix is too large to catch all cases. But, if one just looks at test_summary output before/after a change, one can detect regressions and fix them. Perhaps in some cases you could just limit to -O0 guality if it is something you want to just check if the debug info is represented properly and don't need to test -fvar-tracking-assignments etc. handling - you can just dg-skip-if the tests except for -O0 etc. Similarly, it shouldn't be hard to add tcl function to check for gdb version, and limit some tests only to a particular version of gdb or newer. Jakub