On 19/02/16 13:17 -0700, Sandra Loosemore wrote:
On 02/19/2016 12:01 PM, Jason Merrill wrote:
On 02/19/2016 07:42 AM, Jonathan Wakely wrote:
In PR69864 Manu suggests improving the docs to explain that
-Wnarrowing sometimes produces errors not warnings.

I think the right way to do that is clarify how it interacts with
-std. Specifically that the effect of -Wnarrowing listed first in the
manual *only* applies to C++98 modes, For all later modes (not just
with -std=c++11 as it says now), narrowing conversions produce errors
or warnings by default.

OK for trunk?

OK, thanks.

I suppose the patch is OK as it stands, but I was going to suggest restructuring it so that it talks about the default behavior first and what it does with non-default -std= options after that, instead of vice-versa. Unfortunately I am backlogged on other things right now and it might take me a day or two before I have time to come up with some alternate wording. If we are in a rush, go ahead and commit the existing patch meanwhile, I guess.

I did wonder about that but couldn't come up with wording I liked.

I went ahead and committed it after Jason's OK, but I can take another
look at it next week.

Reply via email to