On 16/02/16 03:22, Jan Hubicka wrote:
On 08/02/16 13:54, Jakub Jelinek wrote:
On Mon, Feb 08, 2016 at 01:46:44PM +0100, Tom de Vries wrote:
[ The pass before pass_omp_simd_clone is pass_dispatcher_calls. It has a
function create_target_clone, similar to simd_clone_create, with a
node.defition and !node.defition part. The !node.defition part does not call
'symtab->call_cgraph_insertion_hooks (new_node)'. ]
I'll defer to Honza or Richi if it is ok not to call cgraph insertion hooks
at this point (and since when they can be avoided), or what else should be
done.
The patch could be ok even for 6.0, not just stage1, if they are ok with it
(or propose some other change).
Ping (Given that Jakub suggested this or an alternative patch might
be included in 6.0 stage4).
Original submission at
https://gcc.gnu.org/ml/gcc-patches/2016-02/msg00543.html .
OK, so the ICE is that you intorduce new deifnition but you set
in_other_partition
and do not really introudce gimple body for it?
In that case we should indeed not call creation hooks, because these are used
only
when new function is introduced to a given partition.
Patch looks OK to me thus.
Committed to trunk.
AFAIU, it's not a release regression given that:
- this has failed since 4.9.0, and
- the test-case is not supported in 4.8,
so we're not required to fix it in 4.9 and 5 branches.
But, the test-case does fail in 5 and 4.9 branches, and the fix seems
simple enough to not have the risk of introducing breakage in the
release branches.
OK for 4.9/5 branch?
Thanks,
- Tom
Honza.
Thanks,
- Tom
Don't call call_cgraph_insertion_hooks in simd_clone_create
2016-02-08 Tom de Vries <t...@codesourcery.com>
PR lto/67709
* omp-low.c (simd_clone_create): Remove call to
symtab->call_cgraph_insertion_hooks.
* testsuite/libgomp.fortran/declare-simd-4.f90: New test.
Jakub
