So do you prefer e.g. following? Bootstrapped/regtested on x86_64-linux and i686-linux.- mode1 = GET_MODE (xop1) != VOIDmode ? GET_MODE (xop1) : mode; + mode1 = (GET_MODE (xop1) != VOIDmode || canonicalize_op1) + ? GET_MODE (xop1) : mode;
Placement of parentheses is wrong for formatting, but otherwise I think this patch is good.
Bernd