On 01/27/2016 05:14 PM, David Edelsohn wrote:
On Wed, Jan 27, 2016 at 6:36 PM, Jeff Law <l...@redhat.com> wrote:
On 01/27/2016 12:39 PM, David Edelsohn wrote:
The new sra-17.c and sra-18.c tests fail on AIX because the regex is
too restrictive -- AIX labels don't have exactly the same format. On
AIX, the labels in the dumps look like "LC..0" instead of ".LC0".
This patch adds "*" and ".*" so that the "." prepended to LC is
optional and to allow characters between the "LC" and the "0".
I needed extra escapes for the sra-17.c line that matches multiple
times - for no apparent reason.
The joys of expect/tcl. I just keep escaping until the regex that I
developed outside the suite works. I have been trying to get away from
using .* though. The longest match nature sometimes gives surprising
results. In theory .*? ought to work better, but I haven't tried using it
much.
Anyway, the change looks fine to me.
Segher pointed out to me that my revised regex was matching multiple
lines, so it was not triggering multiple times without the restriction
on the pattern.
A revised, tighter patch uses "?"
Yup, that's precisely why I've moved away from .* :-)
jeff
