Hi Martin,

On Wed, 27 Jan 2016, Martin Jambor wrote:
> So what would you think about the following?  Perhaps it is too
> verbose but I wanted to mention the few areas users should know 
> have changed, if they happen to try HSA out.  I can certainly 
> cut it down a bit.

I like this.  In fact, in one or two spots we even may want to
be a little bit longer on the changes.html page.  (Definitely a
good idea to split this into the shorter announcement and the
longer one for the release notes.)

> Index: changes.html
> ===================================================================
> +     <li><p>GCC can now generate HSAIL for simple OpenMP device constructs
> +       if configured with <code>--enable-offload-targets=hsa</code>.  A new
> +       libgomp plugin then run these HSAIL kernels implementing these
> +       constructs on HSA capable GPUs via standard HSA run-time.</p>

"run" -> "runs"

"via a standard HSA"

"run-time" -> "run time" (since it's a noun)

Will everyone know what HSAIL is?  Should we expand the acronym
at first or note (in parenthesis what it is)?

> +       <p>If the HSA compilation back-end determines it cannot output HSAIL
> +       for a particular input, it gives a warning by default.  These
> +       warnings can be suppressed with <code>-Wno-hsa</code>.  To give a
> +       few examples, the HSA back-end does not implement compilation of

"back end"

> +       code using function pointers and variable-sized variables and

"variable-sized variables" is a bit confusing. ;-)  Is there a
better term?  "variable-sized arrays" I know, for example.

> +       <p>When compilation for HSA is enabled, the compiler attempts to
> +       compile composite OpenMP constructs
> +      <blockquote><pre>
> +#pragma omp target teams distribute parallel for</pre></blockquote>
> +      into parallel HSA GPU kernels.</p>

Above we had "HSAIL kernels", here "HSA GPU kernels".  Should we
converge on one?

> Index: index.html
> ===================================================================
> +<dt><span> Heterogeneous Systems Architecture support in GCC</span>

Here I would omit the "in GCC" since this is our main page.

> +     <span class="date">[2016-01-27]</span></dt>
> +     <dd><a href="http://www.hsafoundation.com/";> Heterogeneous Systems
> +     Architecture 1.0</a> <a 
> href="https://gcc.gnu.org/gcc-6/changes.html#hsa";>
> +     support was added to GCC.</a>  Contributed by Martin Jambor, Martin 
> Liška
> +     and Michael Matz from SUSE.</dd>

How about "to GCC</a>, contributed by..."?

Not too long for the main page I'd say.


This is okay with the changes/considering the questions above.

Gerald

Reply via email to