On 23/12/15 15:56 -0500, Jason Merrill wrote:
On 12/23/2015 12:35 PM, Torvald Riegel wrote:
+//#if !defined (HAVE_ELF_STYLE_WEAKREF)
Can I assume weak refs to be supported, or how do I check for whether
they are?  What's your preference?

G++ does support targets without weak symbols, but I imagine we can decide not to support libitm on such targets.

+  // FIXME make a true compile-time choice to prevent warnings.
+  if (sizeof(uint64_t)== sizeof(void*))
+    return (void*)_ITM_RU8((const uint64_t*)ptr);
+  else
+    return (void*)_ITM_RU4((const uint32_t*)ptr);

#include <stdint.h> and compare UINTPTR_MAX to UINT64_MAX?

Presumably that header is already included to use uint32_t and
uint64_t, but even if not there are pre-defined versions of those
macros that don't need any header, __UINTPTR_MAX__ and __UINT64_MAX__.

Reply via email to