Hi Steve, I have run out of time because I am just about to set off to the UK for Christmas. I only have trunk installed on my laptop, although I might just load up 5 branch. I'll be back on the 29th and will deal with this backport then.
Cheers Paul On 18 December 2015 at 19:58, Paul Richard Thomas <paul.richard.tho...@gmail.com> wrote: > Hi Steve, > > The patch is almost exactly as you reviewed before. The tweaks to > trans.c came about because of other patches that prevented this one > from applying. Please concentrate on the modified testcase and let me > know if you would like me to make it work as it does in 6 branch. I > will take a quick look to see how much work is involved. > > Thanks > > Paul > > On 18 December 2015 at 19:39, Steve Kargl > <s...@troutmask.apl.washington.edu> wrote: >> On Fri, Dec 18, 2015 at 07:12:47PM +0100, Paul Richard Thomas wrote: >>> >>> I have just applied the patch to 5 branch and have found that, apart >>> from two minor tweaks in trans.c, all was well. It bootstrapped >>> and regtested fine, apart from deferred_character_2.f90. In this >>> latter, deferred length SOURCE and MOLD do not work because the >>> requisite patches in gfc_trans_allocate were not backported. In >>> addition, I had to add explicit array specifications to the allocate >>> statements. >>> >>> Should I get deferred length SOURCE and MOLD to work or apply the >>> attached patch as it stands? Alternatively, I could forget about 4.9 >>> and 5 branches and close the PRs. >>> >>> I have added the ChangeLogs below. >>> >> >> I'll review this tonight or tomorrow morning. >> >> As to your question, I think that it is time to let 4.9 go. >> AFAIK, there is going to be only one more release from the 4 >> branch. Too many PRs, too few hands to fix them. Hopefully, >> major OS's will move to 5.x as the recommended gcc distro. >> >> I think backports to the 5 branch should be done at the >> disgression of the committer. If you have cycles to burn, >> backporting is up to you. One problem with this viewpoint >> is, of course, code divergence between 5-branch and trunk >> makes backporting more difficult. >> >> -- >> steve > > > > -- > Outside of a dog, a book is a man's best friend. Inside of a dog it's > too dark to read. > > Groucho Marx -- Outside of a dog, a book is a man's best friend. Inside of a dog it's too dark to read. Groucho Marx
