On Tue, Dec 15, 2015 at 4:07 PM, Matthew Wahab
<matthew.wa...@foss.arm.com> wrote:
> On 10/12/15 10:49, Ramana Radhakrishnan wrote:
>>
>> On Mon, Dec 7, 2015 at 4:10 PM, Matthew Wahab <matthew.wa...@foss.arm.com>
>> wrote:
>>>
>>> On 27/11/15 17:11, Matthew Wahab wrote:
>>>>
>>>> On 27/11/15 13:44, Christophe Lyon wrote:
>>>>>>
>>>>>> On 26/11/15 16:02, Matthew Wahab wrote
>>>>
>>>>
>>>>>>> This patch adds ARMv8.1 support to GCC Dejagnu, to allow ARM tests to
>>>>>>> specify targest and to set up command line options. It builds on the
>>>>>>> ARMv8.1 target support added for AArch64 tests, partly reworking that
>>>>>>> support to take into account the different configurations that tests
>>>>>>> may
>>>>>>> be run under.
>
> [..]
>>>
>>> # Return 1 if the target supports the ARMv8.1 Adv.SIMD extension, 0 -#
>>> otherwise.  The test is valid for AArch64. +# otherwise.  The test is
>>> valid for
>>> AArch64 and ARM.  Record the command +# line options that needed.
>>
>>
>> s/that//
>
>
> Fixed in attached patch.
>
>> Can you also make sure doc/sourcebuild.texi is updated for this helper
>> function ?
>> If not documented,it would be good to add the documentation for the same
>> while you
>> are here.
>
>
> Done, I've listed them as ARM attributes based on their names.
>
> Tested this and the other update patch (#4/7) for arm-none-eabi with
> cross-compiled
> check-gcc by running the gcc.target/aarch64/advsimd-intrinsics with and
> without ARMv8.1 enabled as a test target.
>
> Ok?

Ok - thanks for dealing with this.


Ramana


> Matthew
>
> testsuite/
> 2015-12-14  Matthew Wahab  <matthew.wa...@arm.com>
>
>         * lib/target-supports.exp (add_options_for_arm_v8_1a_neon): Update
>         comment.  Use check_effective_target_arm_v8_1a_neon_ok to select
>         the command line options.
>         (check_effective_target_arm_v8_1a_neon_ok_nocache): Update initial
>         test to allow ARM targets.  Select and record a working set of
>         command line options.
>         (check_effective_target_arm_v8_1a_neon_hw): Add tests for ARM
>         targets.
>
> gcc/
> 2015-12-14  Matthew Wahab  <matthew.wa...@arm.com>
>
>         * doc/sourcebuild.texi (ARM-specific attributes): Add
>         "arm_v8_1a_neon_ok" and "arm_v8_1a_neon_hw".
>

Reply via email to