On 12/09/2015 02:56 AM, Thomas Preud'homme wrote:
c-c++-common/attr-simd-3.c fails to compile on arm-none-eabi targets due to
-fcilkplus needing -pthread which is not available for those targets. This
patch solves this issue by adding a condition to the cilkplus effective target
that compiling with -fcilkplus succeeds and requires cilkplus as an effective
target for attr-simd-3.c testcase.
ChangeLog entry is as follows:
*** gcc/testsuite/ChangeLog ***
2015-12-08 Thomas Preud'homme <thomas.preudho...@arm.com>
PR testsuite/68629
* lib/target-supports.exp (check_effective_target_cilkplus): Also
check that compiling with -fcilkplus does not give an error.
* c-c++-common/attr-simd-3.c: Require cilkplus effective target.
OK.
Note however, that the simd attribute is now independent of Cilk+. So
generally we shouldn't want/need -fcilkplus for uses of that attribute.
This case is somewhat special in that we're checking for something
that's considered a syntax error for Cilk+, so it probably makes sense
to keep the test as-is.
I do wonder if a complementary test where we try to apply that attribute
to a function (without the vector attribute) and compile without the
-fcilkplus option would be wise. We ought to be throwing some kind of
error in that situation and it'd be useful to verify that's the case.
jeff
