I think marking stuff with Warning as appropriate qualifies as obvious.
On 12/04/2015 05:37 PM, Jakub Jelinek wrote:
+ /* If the switch takes an integer, convert it. */ + if (arg && cl_options[opt_index].cl_uinteger) + { + value = integral_argument (arg); + if (value == -1) + return; + }
So does this issue an error message anywhere or just silently drop the option on the floor if the argument is invalid?
+ /* If the switch takes an enumerated argument, convert it. */ + if (arg && (cl_options[opt_index].var_type == CLVC_ENUM))
Unnecessary parens. Bernd