On Wed, 2 Dec 2015, Jakub Jelinek wrote:

> On Wed, Dec 02, 2015 at 09:16:10PM +0100, Jan Hubicka wrote:
> >     * cfgexpand.c: Include alias.h
> 
> Missing full stop at the end.
> 
> >     (expand_call_stmt, expand_debug_expr): Set no_new_alias_sets;
> >     do not fiddle with flag_strict_aliasing
> 
> Likewise.
> 
> >     * varasm.c: Include alias.h
> 
> Ditto.
> 
> > @@ -1034,6 +1037,10 @@ get_alias_set (tree t)
> >       gcc_checking_assert (p == TYPE_MAIN_VARIANT (p));
> >       if (TYPE_ALIAS_SET_KNOWN_P (p))
> >         set = TYPE_ALIAS_SET (p);
> > +     /* During debug statement expanding we can not allocate new alias sets
> 
> s/expanding/expansion/ ?
> 
> > +  /* During debug statement expanding we can not allocate new alias sets
> 
> Ditto.
> 
> Otherwise, it looks reasonable to me, but please wait for richi's feedback
> on it.

Looks good to me.

Thanks,
Richard.

Reply via email to