On Wed, Dec 02, 2015 at 09:59:10AM +0100, Andreas Krebbel wrote: > On 11/30/2015 03:45 PM, Dominik Vogt wrote: > > On Mon, Nov 09, 2015 at 01:33:23PM +0100, Andreas Krebbel wrote: > >> On 11/04/2015 02:39 AM, Dominik Vogt wrote: > >>> On Tue, Nov 03, 2015 at 06:47:28PM +0100, Ulrich Weigand wrote: > >>>> Dominik Vogt wrote: > > +++ b/gcc/testsuite/gcc.target/s390/md/movstr-1.c > > @@ -0,0 +1,11 @@ > > +/* Machine description pattern tests. */ > > + > > +/* { dg-do assemble } */ > > +/* { dg-options "-dP -save-temps" } */ > > -save-temps is not necessary for a dg-do assemble test.
It *is* necessary for "assemble", but not for "compile" which should be used here. Anyway, I want to upgrade the test to a "run" test that also veryfies whether the generated code does the right thing. > > +# Additional md torture tests. > > +torture-init > > +set MD_TEST_OPTS [list \ > > + {-Os -march=z900} {-Os -march=z13} \ > > + {-O0 -march=z900} {-O0 -march=z13} \ > > + {-O1 -march=z900} {-O1 -march=z13} \ > > + {-O2 -march=z900} {-O2 -march=z13} \ > > + {-O3 -march=z900} {-O3 -march=z13}] > > +set-torture-options $MD_TEST_OPTS > > +gcc-dg-runtest [lsort [glob -nocomplain $md_tests]] "" $DEFAULT_CFLAGS > > torture-finish > > Does it really make sense to use different -march options for the > md/ tests? Whether a certain pattern will match usually depends on > the -march level. I would say the -march option needs to be part > of testcase. Agreed, but I think with "run" tests various -march= and -O options are useful. Ciao Dominik ^_^ ^_^ -- Dominik Vogt IBM Germany