On 27 November 2015 at 18:05, Matthew Wahab <matthew.wa...@foss.arm.com> wrote: > On 27/11/15 14:05, Christophe Lyon wrote: >> >> On 26 November 2015 at 16:55, Matthew Wahab <matthew.wa...@foss.arm.com> >> wrote: > > >>> ARMv8.1 includes an extension to ARM which adds two Adv.SIMD >>> instructions, vqrdmlah and vqrdmlsh. This patch set adds support for >>> ARMv8.1 and for the new instructions, enabling the architecture with >>> --march=armv8.1-a. The new instructions are enabled when both ARMv8.1 >>> and a suitable fpu options are set, for instance with -march=armv8.1-a >>> -mfpu=neon-fp-armv8 -mfloat-abi=hard. >>> >>> This patch set adds the command line options and internal feature >>> macros. Following patches >>> - enable multilib support for ARMv8.1, >>> - add patterns for the new instructions, >>> - add the ACLE feature macro for the ARMv8.1 extensions, >>> - extend target support in the testsuite to ARMv8.1, >>> - add the ACLE intrinsics for vqrmdl{as}h and >>> - add the ACLE intrinsics for vqrmdl{as}h_lane. >>> > >> >> The whole series LGTM, but do you plan to add tests for the new >> intrinsics? > > > The Adv.SIMD intrinsics tests are in gcc.target/aarch64/advsimd-intrinsics, > they get run for both AArch64 and ARM backends. The tests for the new > intrinsics were added (yesterday) by the AArch64 version of this patch. >
Ha yes, of course. > Matthew