On 08/05/2011 01:04 PM, Dodji Seketeli wrote:
Jason Merrill<ja...@redhat.com>  writes:

Why not 0xFFFFFFFF?  I'm not sure what the rationale for using that
value here:

           /* If the column number is ridiculous or we've allocated a huge
              number of source_locations, give up on column numbers. */
           max_column_hint = 0;
-         if (highest>0xF0000000)
+         if (highest>  MAX_SOURCE_LOCATION)
             return 0;

was, but I would think that we would be fine to use that upper range
for macro maps.

I have no idea where the 0xF0000000 comes from.  I have now set it to
0xFFFFFFFF and it passed bootstrap + tests fine.

Sorry, I should have been clearer; I think we want to leave this test alone so that ordinary locations don't grow past 0xF0000000, leaving the top range for macro locations.

Jason

Reply via email to