It's not clear to me whether I should be passing in UNKNOWN_LOCATION
or input_location to the various functions.

cp_build_unary_op used input_location in various places internally,
so I've passed that in wherever there isn't a better value.

Rather than try to get this right now I'm inclined to save it for the next stage 1 and go back to protected_set_expr_location for GCC 6.

Bootstraps (on x86_64-pc-linux-gnu), but regresses some tests, due to
changes in locations at which diagnostics are emitted:

  c-c++-common/cilk-plus/CK/cilk_for_errors.c
  c-c++-common/cilk-plus/PS/for1.c
  c-c++-common/gomp/pr59073.c
  g++.dg/cpp0x/nsdmi-template14.C
  g++.dg/gomp/for-1.C
  g++.dg/gomp/pr39495-2.C
  g++.dg/init/new38.C
  g++.dg/warn/Wconversion-real-integer2.C
  g++.dg/warn/pr35635.C

Are the changes good or bad?

Jason

Reply via email to