Hi Caroline,
> All of the patch looks good to me, but I can only approve the libvtv
> portion (which I do). Someone else will need to approve the rest.
thanks. Jeff did so in the meantime.
>>> * Like Cygwin, Solaris has no obstack functions in libc, so I'm now
>>> using a common conditional for that.
Just for the record, since I forgot to explain it in the submission:
* Makefile.am [VTV_NO_OBSTACK] (obstack.c): Use new condition.
Create empty config.h
Between my initial libvtv port and the submission, current gnulib
obstack.[ch] got imported into libiberty. obstack.c now unconditionally
includes <config.h>, which doesn't exist in libvtv. Given that libvtv
isn't built by default, nobody noticed, and it would have shown up on
Cygwin only anyway. AFAICS, it's not strictly needed, though: the only
macros tested in obstack.c not predefined by either the compiler or libc
are
ENABLE_NLS
HAVE_LIBINTL_H
_OBSTACK_ELIDE_CODE
_OBSTACK_NO_ERROR_HANDLER
Given that libvtv isn't currently localized, the NLS stuff seemed
unimportant, so I just create an empty/fake config.h.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
