On 11/23/2015 02:49 PM, marxin wrote:
Following series has been just bootregtested on x86_64-linux-gnu
(all patches together).

All ok except 5/6 which I'm not finding obvious. Better to have a cilk/c++ person have a look.

In the future, a few more explanations would help with reviewing. Let's say for 4/6, how does the leak occur?

Some changes appear beneficial but unnecessary (converting explicitly released vecs to auto_vecs), and:

 static vec<tree, va_gc> *
-create_array_refs (location_t loc, vec<vec<an_parts> > an_info,
+create_array_refs (location_t loc, const vec<vec<an_parts> > &an_info,
                   vec<an_loop_parts> an_loop_info, size_t size,  size_t rank)

How does this help prevent leaks? In general we don't want non-bugfixes at this stage.


Bernd

Reply via email to