On Sun, Nov 22, 2015 at 06:24:19PM -0700, Michael Collison wrote: > > > On 11/22/2015 8:48 AM, James Greenhalgh wrote: > >On Sun, Nov 08, 2015 at 11:51:47PM -0700, Michael Collison wrote: > >>2015-11-06 Michael Collison <michael.colli...@linaro.org> > >> * config/aarch64/aarch64-simd.md (widen_ssum, widen_usum) > >>(aarch64_<ANY_EXTEND:su><ADDSUB:optab>w<mode>_internal): New patterns > >> * config/aarch64/iterators.md (Vhalf, VDBLW): New mode attributes. > >> * gcc.target/aarch64/saddw-1.c: New test. > >> * gcc.target/aarch64/saddw-2.c: New test. > >> * gcc.target/aarch64/uaddw-1.c: New test. > >> * gcc.target/aarch64/uaddw-2.c: New test. > >> * gcc.target/aarch64/uaddw-3.c: New test. > >> * lib/target-support.exp > >> (check_effective_target_vect_widen_sum_hi_to_si_pattern): > >> Add aarch64 to list of support targets. > > > >These hunks are all OK (with the minor style comments below applied). > > Okay I will update with your comments. > > > >As we understand what's happening here, let's take the regressions below > >for now and add AArch64 to the targets affected by pr68333. > > > >> * gcc.dg/vect/slp-multitypes-4.c: Disable test for > >> targets with widening adds from V8HI=>V4SI. > >> * gcc.dg/vect/slp-multitypes-5.c: Ditto. > >> * gcc.dg/vect/vect-125.c: Ditto. > >Let's leave these for now, while we wait for pr68333. > > To clarify you would like me to exclude these bits from the patch?
Yes, given the direction that pr68333 is going (a bug that should be fixed, rather than an expected failure) that seems best to me. Thanks, James
