On 17/11/15 02:00, Ed Smith-Rowland wrote:
On 11/16/2015 07:28 PM, Florian Goth wrote:
Any particular pointers how I can help in improving the implementation?
Immediately: I have a good patch with xfails where #include <math.h> should
inject into namespace std. That's
probably a one liner in the makefiles that's better done in tree. That stuff
kills me.
The values checking and NaN checking is very good.
there are several correctness bugs visible in the code.
(e.g. sinc(inf) returning nan instead of 0.)
so at least test all combinations of special numbers
(+-0, +-inf, qnan, and possibly a few other points
including subnormal, small normal large normal input,
this helped me catch corner-case bugs in musl math lib).
it would be nice to know something about the expected
accuracy of these functions (some of them i'd guess
to be hard to implement with low ulp errors).
