Rich Felker <dal...@libc.org> wrote:
> The "chk_guard_add" pattern used for loading the GOT slot address for
> __stack_chk_guard hard-codes use of r12 as a fixed GOT register and
> thus is not suitable for FDPIC, where the saved initial value of r12
> from function entry is what we need.
The patch is OK. Committed as revision 230366.
> I would actually prefer removing this hack entirely if possible. I
> tried non-FDPIC with it disabled and did not experience any problems;
> I suspect it was written to work around a bug that no longer exists.
Even we don't see the problem without that, it'll be a latent
issue with the old reload, I think. When SH switches to LRA
completely, this should be revisit.
Regards,
kaz
