On Tue, Nov 3, 2015 at 10:26 AM, Paolo Carlini <paolo.carl...@oracle.com> wrote: > Hi, > > On 11/03/2015 01:35 PM, Aurelio Remonda wrote: >> >> diff --git a/ChangeLog b/ChangeLog >> index 5b16ca2..a1cd0d3 100644 >> --- a/ChangeLog >> +++ b/ChangeLog >> @@ -1,3 +1,12 @@ >> +2015-10-30 Aurelio Remonda <aurelio.remo...@tallertechnologies.com> >> + >> + * libstdc++-v3/acinclude.m4: add >> enable_new_opnt_no_allocation_retry >> + flag definition. >> + * libstdc++-v3/configure.ac: add option flag >> + GLIBCXX_ENABLE_NEW_OPNT_NO_ALLOCATION_RETRY >> + * libstdc++-v3/libsupc++/new_opnt.cc use the defined macro >> + * libstdc++-v3/doc/xml/manual/configure.xml >> + > > Three minor comments. First, ChangeLog entries aren't normally submitted as > part of the patch. Second, since the ChangeLog is under libstdc++-v3, the > ChangeLog entries should not have libstdc++-v3 in the paths (eg, just * > acinclude.m4: ...).
Ok, so ChangeLog modifications should be another patch? >Finally, since you are touching acinclude.m4 you should > normally run autoreconf, mention in the ChangeLog the changed regenerated > files and eventually commit those changes too (like the ChangeLog entries, > those aren't normally part of the posted patch) About the three issues, you > have plenty of examples in the mailing list. I have a problem with autoreconf, when i run it with autoconf 2.69 it says i need exactly autoconf 2.64 so i install it and try to do autoreconf with 2.64 and this is what i get: aurelio-remonda@Remonda-PC:~/gcc/libstdc++-v3$ autoreconf configure.ac:74: error: Autoconf version 2.65 or higher is required You can see i am using my recently installed autoconf: aurelio-remonda@Remonda-PC:~/gcc/libstdc++-v3$ which autoconf /home/aurelio-remonda/autoconf-2.64/install/bin/autoconf I even try 2.65: aurelio-remonda@Remonda-PC:~/gcc/libstdc++-v3$ which autoreconf /home/aurelio-remonda/autoconf-2.65/install/bin/autoreconf and got this: aurelio-remonda@Remonda-PC:~/gcc/libstdc++-v3$ autoreconf configure.ac:4: error: Please use exactly Autoconf 2.64 instead of 2.65. ../config/override.m4:12: _GCC_AUTOCONF_VERSION_CHECK is expanded from... configure.ac:4: the top level autom4te: /usr/bin/m4 failed with exit status: 1 aclocal: error: echo failed with exit status: 1 autoreconf: aclocal failed with exit status: 1 So i changed the version here: /src/gcc/libstdc++-v3/configure.ac:3 AC_PREREQ(2.69) And here: /src/config/override.m4:59 m4_if(m4_defn([m4_PACKAGE_VERSION]), [2.69] And did the autoreconf with 2.69 and that worked. But Jonathan told me that i don't have to make those changes. -- Aurelio Remonda Software Engineer San Lorenzo 47, 3rd Floor, Office 5 Córdoba, Argentina Phone: +54-351-4217888 / 4218211
