On 10/30/2015 04:16 PM, Nathan Sidwell wrote:
On 10/30/15 14:28, Jeff Law wrote:
So when we don't use src_reg or dst_mode, we'll get a warning about
the unused
variable. I guess this is the first port where HARD_REGNO_NREGS is a
constant.
Yeah, I noticed that when first lookingat the port, but as it wasn't
(apparently) broken ...
It's only fatal with -Wjumble-mumble that gets set by config-list.mk, so
it could have been easily sneaking by. Certainly wouldn't affect the
correctness of the compiler though.
Second, MOVE_MAX is 4. That's causing out-of-bounds array access
warnings in
various places.
There were a variety of other problems associated with MOVE_MAX being
smaller
than a word. If I change MOVE_MAX to 8, then everything is good.
Makes sense.
I find myself wondering if that ought to be explicitly sanity-checked
somewhere. I'm sure there's a significant number of invariants for
ports that we could check at build time and hopefully prevent problems
of this nature in the future. Though it may not be worth it..
Testing attached ...
Cool. I'll go ahead and add nvptx-elf to the list shortly on the
assumption this stuff will get fixed on way or another.
Jeff
